New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gamess memory changes #421

Open

loriab wants to merge 1 commit into MolSSI:master from loriab:taylor_gamess_mem

Collaborator

loriab commented Aug 8, 2023

Description

This was originally proposed in #401 but there was some trouble #401 (review) so separated out. Taylor reports that the system__mwords change needed to run GAMESS on Perlmutter.

Changelog description

Status

Code base linted
Ready to go


          gamess memory changes

codecov bot commented Aug 8, 2023 •

edited

Loading

Codecov Report

Merging #421 (5267495) into master (034fd1a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

github-advanced-security bot found potential problems

View reviewed changes

qcengine/programs/gamess/runner.py

+                              mwords, memddi = self._partition(mwords_total, mem_frac_replicated, config.ncores)
+                              # DEBUG print(f"loop {mwords_total=} {mem_frac_replicated=} {config.ncores=} -> repl: {mwords=} dist: {memddi=} -> percore={memddi/config.ncores + mwords} tot={memddi + config.ncores * mwords}\n")
+                              trial_opts = copy.deepcopy(opts)
+                              trial_opts["contrl__exetyp"] = "check"

Check failure

Code scanning / CodeQL

Modification of parameter with default

This expression mutates a [default value](1).

qcengine/programs/gamess/runner.py

+                              # DEBUG print(f"loop {mwords_total=} {mem_frac_replicated=} {config.ncores=} -> repl: {mwords=} dist: {memddi=} -> percore={memddi/config.ncores + mwords} tot={memddi + config.ncores * mwords}\n")
+                              trial_opts = copy.deepcopy(opts)
+                              trial_opts["contrl__exetyp"] = "check"
+                              trial_opts["system__parall"] = not (config.ncores == 1)

Check failure

Code scanning / CodeQL

Modification of parameter with default

This expression mutates a [default value](1).

qcengine/programs/gamess/runner.py

+                              trial_opts = copy.deepcopy(opts)
+                              trial_opts["contrl__exetyp"] = "check"
+                              trial_opts["system__parall"] = not (config.ncores == 1)
+                              trial_opts["system__mwords"] = mwords

Check failure

Code scanning / CodeQL

Modification of parameter with default

This expression mutates a [default value](1).

qcengine/programs/gamess/runner.py

+                              trial_opts["contrl__exetyp"] = "check"
+                              trial_opts["system__parall"] = not (config.ncores == 1)
+                              trial_opts["system__mwords"] = mwords
+                              trial_opts["system__memddi"] = memddi

Check failure

Code scanning / CodeQL

Modification of parameter with default

This expression mutates a [default value](1).

qcengine/programs/gamess/runner.py

+                              elif "EXECUTION OF GAMESS TERMINATED -ABNORMALLY-" in dexe["stdout"]:
+                                  pass
+                              else:
+                                  opts["system__mwords"] = mwords

Check failure

Code scanning / CodeQL

Modification of parameter with default

This expression mutates a [default value](1).

qcengine/programs/gamess/runner.py

+                                  pass
+                              else:
+                                  opts["system__mwords"] = mwords
+                                  opts["system__memddi"] = memddi

Check failure

Code scanning / CodeQL

Modification of parameter with default

This expression mutates a [default value](1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet